レスポンスないね〜 †忙しいのかな? Hi Paul-san We are waiting for your reply. Are you busy ? In our source, Is there a part that should be corrected ? Paulさんから速攻で返事が返ってきた。(+0300 (EEST))ってことはヨーロッパの人なのかな? It looks fine as it is now, thanks. Unfortunately I have been sidetracked with some other items, so I haven't had a chance to commit it yet. If someone doesn't beat me to it, I'll try to get to it shortly. Sorry for the delay. 急がすつもりは全然なくって、ただ単に返事が知りたかっただけなので、下記のように返事を出す。 Thank you for quick answer. We wanted merely to hear the answer. No problem to waiting. Please go by the priority level for which you hope. 胡桃さんより、「通常1ヶ月程度はかかるので、慌てないで!」というコメントを頂きました。 宿題2 †
1.drivers/charのルール … 了解 †On Fri, Sep 16, 2005 at 10:46:06PM +0900, kogiidena wrote: > - rtc.c > I separated rtc.c to new rtc.c and rs5c313_rtc.c. > May I put rs5c313_rtc.c to driver/char directory ?. > Though it noticed later, becase, > > 1) rs5c313_rtc.c is depend on SH4-SCI and LANDISK's FPGA functions. > 2) LANDISK's FPGA function is not open, so, analysis is very difficult. > > May I put such a source on a general place ? > This is fine, there are plenty of things in drivers/char that are very much platform dependant. It is however still a more correct place to store these sorts of things. It's also easier to make it more platform agnostic if in the future someone wants to do the work to get it working on something else.
2.boards/landisk ディレクトリのルール … 完了 †> - landisk_pwb.c > landisk_pwb.c handles very board specific functions implemented with the > FPGA. > For example, POWER SWITCH Control, another Button Control, LED control, > buzzer > control are included. > Could one really reuse it for the other boards or archs ? > We hope it store to board/landisk directory. > This is a matter of taste I suppose. MIPS traditionally dumps these in drivers/char, and ARM generally keeps these in the board-specific directories. I suppose there's no problem in leaving it where it is for now.
3. コードクリーニングその1 … 完了 †On Mon, Sep 19, 2005 at 09:54:35PM +0900, kogiidena wrote: > We modified the patch of LANDISK > > (1) I separated rtc.c to new rtc.c and drivers/char/rs5c313_rtc.c > (2) rs5c313_rtc.c was rewritten to operate as a driver. > (3) scripts/Lindent was used. > (4) mach.c used c99 initializers. > (5) mach.c was put in setup.c > (6) IDE_ARCH_OBSOLETE_INIT and __WANT_IO_DEF are removed. > > Please teach me when there is a point that should be corrected. > > (a) > http://eggplant.ddo.jp/www/download/kernel26/merge/landisk-flat3-arch-sh.patch This looks ok. One minor thing would be to delete all of the commented out and unused/dead code from the patch, as there seems to be quite a lot of it (for debugging I suppose), and we don't really want that. Other than that, it looks ok.
4. コードクリーニングその2 … 完了 †> (b) > http://eggplant.ddo.jp/www/download/kernel26/merge/landisk-flat3-include.patch Much better.
5. コードクリーニングその3 … 完了 †> (c) > http://eggplant.ddo.jp/www/download/kernel26/merge/landisk-flat3-drivers.patch > This generally also looks ok. It would be nice if the rs5c313_rtc.c driver would consolidate all of the copyrights/header stuff at the top of the file (as things like ds1286.c do, for instance). If you can fix those few minor issues, I'll merge it.
宿題1 †1.Thanks †On Wed, Sep 14, 2005 at 01:54:11AM +0900, kogiidena wrote: > We ported LinuxSH to LANDISK made by I-O DATA DEVICE, INC. > We hope for merging the source to LinuxSH. > Can we contribute it to LinuxSH, if it's ok ? > > patch is in here: > http://eggplant.ddo.jp/www/download/kernel26/merge/landisk-support-flat.patch > Most of the board-specific parts look ok, but the driver bits should be moved somewhere else.. and there are a few other minor issues.
2.rtc.c/rs5c313_rtc.c … たぶん完了 †> * arch/sh/boards/landisk/rtc.c: New file. > * arch/sh/boards/landisk/landisk_pwb.c: New file. These should go in to drivers/char. rtc.c should be renamed to something like rs5c313_rtc.c. You can have an rtc.c in the landisk directory, and that's where you should move the gettimeofday/settimeofday and board-specific time init code. Most of the rest of the RTC code is generic, so moving it to drivers/char gives other people a chance to use it (perhaps also add a Kconfig option for it to drivers/char/Kconfig).
3. landisk_pwd.cの分離 … とりあえず放置 †
4.scripts/Lindent … 解決 †At the same time, please also run landisk_pwb.c through scripts/Lindent or something similar, it needs to comply with Documentation/CodingStyle. ソース整形ツールでチェックしてね、ってことかな?
5.c99 initializers … 解決 †> * arch/sh/boards/landisk/setup.c: New file. > * arch/sh/boards/landisk/mach.c: New file. mach.c needs to use c99 initializers, and you can also just inline it in setup.c (as other boards are doing). mach.cは対応可能。
6.define label … 解決 †> * include/asm-sh/irq.h: Add LANDISK support. > * include/asm-sh/landisk/io.h: New file. > * include/asm-sh/landisk/gio.h: New file. > * include/asm-sh/landisk/ide.h: New file. > * include/asm-sh/landisk/iodata_landisk.h: New file. > Can you explain why you are using IDE_ARCH_OBSOLETE_INIT and __WANT_IO_DEF?
7.別件…kexecのrelocate_kernel.c … 解決 † |